Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify emails in release metadata using PyPI user information #16631

Merged
merged 5 commits into from
Sep 16, 2024

Conversation

facutuesca
Copy link
Contributor

@facutuesca facutuesca commented Sep 4, 2024

Part of #8635, this PR starts verifying the emails included in a release's metadata (author_email and maintainer_email) by comparing that email against the public and verified emails of the PyPI project's owners and maintainers.

If the emails match, we include the corresponding field in the "Verified details" section, under the Meta heading.

image

cc @woodruffw

@facutuesca facutuesca requested a review from a team as a code owner September 4, 2024 17:54
@ewdurbin
Copy link
Member

ewdurbin commented Sep 4, 2024

I'm not sure that we want to do this. Since PyPI account email addresses are private, and release metadata is public, this would act as an oracle to determine user email addresses?

We may want to limit this to the case where the user has marked an email address as public.

@woodruffw
Copy link
Member

I'm not sure that we want to do this. Since PyPI account email addresses are private, and release metadata is public, this would act as an oracle to determine user email addresses?

Yeah, agreed -- I think a user leaving their email private is probably a strong signal that they don't want it positively identified by PyPI in a public fashion, even if it's disclosed as part of the metadata anyways.

@facutuesca
Copy link
Contributor Author

We may want to limit this to the case where the user has marked an email address as public.

Makes sense! I changed the code so that now we verify against all emails of an owner/maintainer that are public and verified.

@di di enabled auto-merge (squash) September 16, 2024 16:40
@di di merged commit 17103e0 into pypi:main Sep 16, 2024
18 checks passed
@di di deleted the verified-details-emails branch September 16, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants