diff --git a/src/_pytask/collect_utils.py b/src/_pytask/collect_utils.py index 0a942e3c..ae02fa25 100644 --- a/src/_pytask/collect_utils.py +++ b/src/_pytask/collect_utils.py @@ -589,5 +589,5 @@ def _evolve_instance(x: Any, instance_from_annot: Node | None) -> Any: if not instance_from_annot: return x - instance_from_annot.set_value(x) + instance_from_annot.from_annot(x) return instance_from_annot diff --git a/src/_pytask/node_protocols.py b/src/_pytask/node_protocols.py index 8fd72f69..571b0b83 100644 --- a/src/_pytask/node_protocols.py +++ b/src/_pytask/node_protocols.py @@ -31,7 +31,7 @@ def load(self) -> Any: def save(self, value: Any) -> Any: ... - def set_value(self, value: Any) -> Any: + def from_annot(self, value: Any) -> Any: ... diff --git a/src/_pytask/nodes.py b/src/_pytask/nodes.py index dcd656e6..218dd771 100644 --- a/src/_pytask/nodes.py +++ b/src/_pytask/nodes.py @@ -111,7 +111,7 @@ class PathNode(Node): def path(self) -> Path: return self.value - def set_value(self, value: Path) -> None: + def from_annot(self, value: Path) -> None: """Set path and if other attributes are not set, set sensible defaults.""" if not isinstance(value, Path): raise TypeError("'value' must be a 'pathlib.Path'.") @@ -173,7 +173,7 @@ def load(self) -> Any: def save(self, value: Any) -> NoReturn: raise NotImplementedError - def set_value(self, value: Any) -> None: + def from_annot(self, value: Any) -> None: self.value = value def state(self) -> str | None: diff --git a/tests/test_collect_command.py b/tests/test_collect_command.py index b091e875..41e22849 100644 --- a/tests/test_collect_command.py +++ b/tests/test_collect_command.py @@ -531,7 +531,7 @@ def state(self): def load(self): ... def save(self, value): ... - def set_value(self, value): ... + def from_annot(self, value): ... def task_example( data = CustomNode("custom", "text"), @@ -572,7 +572,7 @@ def save(self, value): with self.path.open("wb") as f: pickle.dump(value, f) - def set_value(self, value): ... + def from_annot(self, value): ... _PATH = Path(__file__).parent.joinpath("in.pkl") diff --git a/tests/test_execute.py b/tests/test_execute.py index 69421085..aa1badd6 100644 --- a/tests/test_execute.py +++ b/tests/test_execute.py @@ -594,7 +594,7 @@ def load(self) -> Any: def save(self, value: Any) -> None: self.path.write_bytes(pickle.dumps(value)) - def set_value(self, value: Any) -> None: ... + def from_annot(self, value: Any) -> None: ... node = PickleNode("pickled_data", Path(__file__).parent.joinpath("data.pkl")) diff --git a/tests/test_node_protocols.py b/tests/test_node_protocols.py index 9cb511c0..02ce9867 100644 --- a/tests/test_node_protocols.py +++ b/tests/test_node_protocols.py @@ -28,7 +28,7 @@ def load(self): def save(self, value): self.value = value - def set_value(self, value): ... + def from_annot(self, value): ... def task_example( @@ -70,7 +70,7 @@ def save(self, value): with self.path.open("wb") as f: pickle.dump(value, f) - def set_value(self, value): ... + def from_annot(self, value): ... _PATH = Path(__file__).parent.joinpath("in.pkl")