Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JolokiaCollector collects all mbeans regardless of mbeans argument configuration #645

Open
alekiv opened this issue May 4, 2017 · 1 comment

Comments

@alekiv
Copy link

alekiv commented May 4, 2017

From documentation:
mbeans argument - Pipe delimited list of MBeans for which to collect stats. If not provided, all stats will be collected.

Actually collector collects all mbeans regardless of configured mbeans. "mbeans" list or regex is used just for filtering out actual mbeans from big list of domain obj. It becomes problem with CassandraJolokiaCollector, since there are much data in JMX and diamond just can't get all data in reasonable time.

Proposal: change Jolokia collector logic and read specified mbeans only if "mbeans" list is set, instead of reading domains all data

@shortdudey123
Copy link
Member

Feel free to submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants