Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collect_without_dimension not in latest release #758

Closed
Jackleberry opened this issue Aug 19, 2021 · 1 comment
Closed

collect_without_dimension not in latest release #758

Jackleberry opened this issue Aug 19, 2021 · 1 comment

Comments

@Jackleberry
Copy link

I'd like to use the collect_without_dimension option when collecting varnish metrics with the cloudwatch handler. I see it in the code base but not in the latest release even though the code was added before the release date.

self.valid_config = ('region', 'collector', 'metric', 'namespace',
                             'name', 'unit', 'collect_by_instance',
                             'collect_without_dimension')

https://github.com/python-diamond/Diamond/blob/master/src/diamond/handler/cloudwatch.py#L88

Would it be possible to create a new release that includes these changes?

@shortdudey123
Copy link
Member

Use #709 to track a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants