Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure thread archive state is also synced when syncing channels #156

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Ensure thread archive state is also synced when syncing channels #156

merged 1 commit into from
Jun 18, 2024

Conversation

ChrisLovering
Copy link
Member

Closes #153

@ChrisLovering ChrisLovering requested a review from jb3 as a code owner June 18, 2024 18:02
@ChrisLovering ChrisLovering mentioned this pull request Jun 18, 2024
Closed
@ChrisLovering ChrisLovering force-pushed the sync-archived-threads branch from b49dd53 to 9219d84 Compare June 18, 2024 18:15
jchristgit
jchristgit approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@jchristgit jchristgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I assume the bug was the lacking support for forum channels in older versions then?

@ChrisLovering
Copy link
Member Author

ChrisLovering commented Jun 18, 2024 •
edited
Loading

Thanks! I assume the bug was the lacking support for forum channels in older versions then?

Nah, the bug was that sync_thread_archive_state wasn't called when syncing channels, it was only called on startup.

The other part of this change isn't relevant to this issue, but added confusion to the function due to not being relevant anymore, as d.py supports forum channels now.

@wookie184
Copy link
Contributor

(and sync_thread_archive_state is needed because the db_thread.archived = thread.archived line was not sufficient as archived threads are not in guild.threads)

wookie184
wookie184 approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@wookie184 wookie184 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jchristgit
Copy link
Member

jchristgit commented Jun 18, 2024 via email

@ChrisLovering ChrisLovering merged commit 9219d84 into main Jun 18, 2024
4 checks passed
@ChrisLovering ChrisLovering deleted the sync-archived-threads branch June 18, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchristgit jchristgit jchristgit approved these changes

@wookie184 wookie184 wookie184 approved these changes

@jb3 jb3 Awaiting requested review from jb3 jb3 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Threads archive state is not synchronized after start
3 participants
@ChrisLovering @wookie184 @jchristgit