-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All numbers are read as Float #100
Labels
Comments
I think we can check for the style
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When reading an excel file that is exported from other libraries, for example caxlsx https://github.com/caxlsx/caxlsx
The library generates Excel with floats and integers represented with t="n", for example from the "sheet1.xml"
Both of these numbers are read by Creek as: 1.0 , 114.0, which is causing problems when the system expects to see an integer value instead of float, for example when using that number to load Models from the Database
I have found in this line https://github.com/pythonicrubyist/creek/blob/master/lib/creek/styles/converter.rb#L47
That Creek always read the value as float.
My suggestion is to replace
with
I don't know if this is the right solution or not, but by applying this as a patch in the system solved our problem.
The text was updated successfully, but these errors were encountered: