Move binary Docker manywheel and conda build workflows and scripts to pytorch/pytorch repo #1849
Assignees
Comments
This was referenced Jun 12, 2024
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this issue
Jul 25, 2024
#129022) Migration of Docker conda builds to pytorch/pytorch from pytorch/builder: https://github.com/pytorch/builder/blob/main/.github/workflows/build-conda-images.yml Related to: pytorch/builder#1849 Migrate scripts and worklfows, adds logic to execute on PR and upload to ecr with github hash tag in order to test Docker build and nightly on PR. Test when executing on PR, upload to ecr: https://github.com/pytorch/pytorch/actions/runs/9799439218/job/27059691327 ``` 308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/conda-builder-cpu:789cf8fcd738088860056160f6e9ea7cd005972b ``` Test With-Push, upload to dockerhub: https://github.com/pytorch/pytorch/actions/runs/9799783407/job/27060633427 ``` docker.io/pytorch/conda-builder:cpu done ``` Will upload here: https://hub.docker.com/r/pytorch/conda-builder/ Test using ecr image in the nightly workflow: https://github.com/pytorch/pytorch/actions/runs/9798428933/job/27057835235#step:16:87 Note: This is first part that will build docker and upload it to either dockerhub or ecr. After merging followup PR will need to change conda nightly workflows to either use ecr image or dockerhub image, depending if we are running it on PR or from main/release branch. Cleanup of workflows and scripts from builder repo: pytorch/builder#1923 Co-authored-by: atalman <atalman@fb.com> Pull Request resolved: #129022 Approved by: https://github.com/atalman, https://github.com/seemethere, https://github.com/malfet, https://github.com/chuanqi129
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I propose to:
Move Conda Docker build workflows and scripts:
https://github.com/pytorch/builder/blob/main/.github/workflows/build-conda-images.yml
Move Docker images workflows are all required Docker recipes and associated scripts to pytorch/pytorch so that we can test the Docker builds and binary nightly builds in single PR:
https://github.com/pytorch/builder/blob/main/.github/workflows/build-manywheel-images.yml
https://github.com/pytorch/builder/blob/main/.github/workflows/build-libtorch-images.yml
This should facilitate doing cuda, cudnn updates, will require less pinning. Will increase visibility for these workflows
cc @nWEIdia @tinglvv @ptrblck @malfet @juliagmt-google
The text was updated successfully, but these errors were encountered: