Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change general option --verbose to handle levels of verbosity #1032

Open
KSchopmeyer opened this issue Jul 21, 2021 · 1 comment
Open

Change general option --verbose to handle levels of verbosity #1032

KSchopmeyer opened this issue Jul 21, 2021 · 1 comment

Comments

@KSchopmeyer
Copy link
Contributor

KSchopmeyer commented Jul 21, 2021

Change the general option itself to handle multiple levels of verbosity.

thus -v would be as today, -vv would be more detail, etc.

That is the easy part, the hard part is to select what should be displayed at each level.

I propose the following as a starting point for discussion:

-v - msgs on overall status of commands as they proceed. Here is a proposal for the levels.

Level 1 - High level flow through complex code.

  1. The status messages from compiling scripts
  2. MOF compile messages
  3. server connect and disconnect.

In effect, that would be the existing commands.

Level 2

An ouput for those commands that return nothing or today just ouput an indication that the command executed. This would be confirmation that the command executed when level 2 was set but nothing when not set.

Level 3
I propose that for level 3, we add the display of commands as they are executed including the command group, the command, and the parameters. While the commands are generally obvious when done through stdin, they are not at all obvious.

Since the responses to commands (data or exceptions) is generally obvious, except for those few commands that when successful return nothing or a conditional output covered by level 2, there is no need for any more output at level 3.

Level 4
I have not ideas for level 4

NOTE: the other question is whether the levels are cumulative or not. Does level 3 show level 1,2,3 messages. As a first pr, I would propose that we do:

  1. Modify the --verbose option
  2. Add common logic to name the levels.
  3. Leave all the current outputs as is since there are level 1 and should display any time verbose exists.
  4. Add the option to display the command that will be executed.
@andy-maier
Copy link
Contributor

The current proposal is not optimal, for example when a user wants to see the commands because they pipe them from stdin, they need to turn on level 3 and need to consume all the stuff from level 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants