Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stacked error messages. #32

Open
qascade opened this issue Aug 25, 2022 · 5 comments
Open

fix: stacked error messages. #32

qascade opened this issue Aug 25, 2022 · 5 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@qascade
Copy link
Owner

qascade commented Aug 25, 2022

As our major focus was on streaming feature to start. Not much care was taken while writing err messages. Need to modify err messages to only show the direct cause of the err.

@qascade qascade added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Aug 25, 2022
@katarzynakawala
Copy link
Contributor

Hi! Could I work on it?

@qascade
Copy link
Owner Author

qascade commented Sep 28, 2022

@katarzynakawala Sure, assigning this to you. If you have any questions do let me know. I would recommend raising a PR after 1 Oct, if you are participating in Hacktoberfest. I posted this issue because I was seeing nested err messages and it would better to implement errors from the user perspective rather than the developer perspective. Currently the errors are lying around everywhere to help debug stuff which is not an ideal behaviour.

@qascade
Copy link
Owner Author

qascade commented Sep 28, 2022

You can also try using a logger to help developers debug

@qascade
Copy link
Owner Author

qascade commented Sep 29, 2022

@katarzynakawala You can also look at modifying message outputs to look better.

@katarzynakawala
Copy link
Contributor

#59

@qascade qascade changed the title We need better error messages. fix: stacked error messages. May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants