Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Catch KeyboardInterrupts (CTRL-C) in the CLI #160

Open
1 of 4 tasks
tomasr8 opened this issue Sep 29, 2023 · 1 comment
Open
1 of 4 tasks

[Feature Request] Catch KeyboardInterrupts (CTRL-C) in the CLI #160

tomasr8 opened this issue Sep 29, 2023 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@tomasr8
Copy link

tomasr8 commented Sep 29, 2023

Feature Request Type

  • Core functionality
  • Add-on hardware support (eg. audio, RGB, OLED screen, etc.)
  • Alteration (enhancement/optimization) of existing feature(s)
  • New behavior

Description

Currently when you press CTRL-C while the CLI is running, you'll see the default Python behavior of showing the (sometimes very long) traceback. This is rarely going to be useful and just clutters the terminal output.

I suggest that we catch KeyboardInterrupts (can be done globally with a signal handler as well) and just exit w/o printing anything. or perhaps just a short message like Pressed CTRL-C or something like that. Thoughts?

@tomasr8 tomasr8 added enhancement New feature or request help wanted Extra attention is needed labels Sep 29, 2023
@zvecr zvecr transferred this issue from qmk/qmk_firmware Oct 3, 2023
@fauxpark
Copy link
Member

fauxpark commented Oct 3, 2023

This is probably an issue for https://github.com/clueboard/milc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants