Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add keymaps for handwired/dactyl_lightcycle and handwired/dactyl_maximus #1282

Merged
merged 4 commits into from
Jul 10, 2023
Merged

add keymaps for handwired/dactyl_lightcycle and handwired/dactyl_maximus #1282

merged 4 commits into from
Jul 10, 2023

Conversation

dunk2k
Copy link
Contributor

@dunk2k dunk2k commented Jul 5, 2023

Description

As titled

@dunk2k dunk2k marked this pull request as ready for review July 5, 2023 09:07
@dunk2k dunk2k changed the title add keymaps for handwired/dactyl_lightcycyle and handwired/dactyl__maximus add keymaps for handwired/dactyl_lightcycyle and handwired/dactyl_maximus Jul 5, 2023
@dunk2k dunk2k changed the title add keymaps for handwired/dactyl_lightcycyle and handwired/dactyl_maximus add keymaps for handwired/dactyl_lightcycle and handwired/dactyl_maximus Jul 5, 2023
noroadsleft
noroadsleft requested changes Jul 10, 2023
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, it looks like your info.json layout data on the qmk_firmware side isn't accurate.

image

public/keymaps/h/handwired_dactyl_lightcycle_default.json Outdated Show resolved Hide resolved
@dunk2k @noroadsleft
Update handwired_dactyl_lightcycle_default.json
ce48964 
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@noroadsleft noroadsleft merged commit 525943f into qmk:master Jul 10, 2023
2 checks passed
@noroadsleft
Copy link
Member

Thanks!

@dunk2k
Copy link
Contributor Author

dunk2k commented Jul 10, 2023 •
edited
Loading

Thanks!

@noroadsleft On the contrary, thank you 😊

@dunk2k dunk2k deleted the dactyl_lc_max branch July 10, 2023 22:38
@dunk2k dunk2k mentioned this pull request Jul 10, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dunk2k @noroadsleft