Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samebases(::AbstractOperator, ...) should use calls to basis instead of assuming internal layout for the structures #25

Open
Krastanov opened this issue Jul 19, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@Krastanov
Copy link
Collaborator

Krastanov commented Jul 19, 2024

See here:

samebases(a::AbstractOperator) = samebases(a.basis_l, a.basis_r)::Bool
samebases(a::AbstractOperator, b::AbstractOperator) = samebases(a.basis_l, b.basis_l)::Bool && samebases(a.basis_r, b.basis_r)::Bool
check_samebases(a::Union{AbstractOperator, AbstractSuperOperator}) = check_samebases(a.basis_l, a.basis_r)

Assuming that these structures internally have .basis fields breaks in many important cases. This should instead just use formalized interfaces like calls to basis.

This is a special case of issue #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant