Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document and warn that identityoperator(::DenseOperator) returns an (inefficient) DenseOperator type #118

Open
Krastanov opened this issue Jul 5, 2023 · 0 comments
Open

document and warn that identityoperator(::DenseOperator) returns an (inefficient) DenseOperator type #118

Krastanov opened this issue Jul 5, 2023 · 0 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@Krastanov
Copy link
Collaborator

And that it is better to use identityoperator(basis(::DenseOperator)).

Maybe down the line consider changing that convention. The reason of the convention is that we are mimicking Base.one, but that leads to inefficiencies.

Discussed more at #116 (comment)
@Krastanov Krastanov added documentation Improvements or additions to documentation good first issue Good for newcomers labels Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Krastanov