Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky test OverrideBuildTimeConfigTest #44559

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Fix flaky test OverrideBuildTimeConfigTest #44559

merged 1 commit into from
Nov 19, 2024
+7 −9

Conversation

radcortez
Copy link
Member

@radcortez radcortez commented Nov 18, 2024 •
edited
Loading

@quarkusio quarkusio deleted a comment from quarkus-bot bot Nov 18, 2024
@radcortez radcortez marked this pull request as draft November 18, 2024 10:41
@radcortez
Copy link
Member Author

Waiting to collect more information with #44534

gsmet
gsmet reviewed Nov 18, 2024
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I added a small comment.

We will need to get this in before tomorrow evening to make sure it's included in 3.17.0.

core/runtime/src/main/java/io/quarkus/runtime/configuration/ConfigRecorder.java Outdated
@@ -1,5 +1,6 @@
package io.quarkus.runtime.configuration;

import static io.quarkus.runtime.ConfigConfig.*;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want the star imports.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange. I thought the impsort plugin would get rid of it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, no, it doesn't handle star imports.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, have you tried making the process as slow as possible to reproduce it? Either with nice or by lowering your CPU frequency?

Experience shows that CI slowness usually make concurrency issues pop up.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not... I'll try it.

@radcortez radcortez force-pushed the flaky-OverrideBuildTimeConfigTest branch from ad7a6d0 to 8e04549 Compare November 18, 2024 13:20
@radcortez radcortez marked this pull request as ready for review November 19, 2024 10:41
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Nov 19, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 8e04549.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit 274b4b4 into quarkusio:main Nov 19, 2024
67 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Nov 19, 2024
@radcortez radcortez mentioned this pull request Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/config area/core
Projects
None yet
Milestone
3.18 - main
Development

Successfully merging this pull request may close these issues.
2 participants
@radcortez @gsmet