Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brand documentation should include information about how brand interacts with theme #11604

Closed
gadenbuie opened this issue Dec 2, 2024 · 3 comments
Assignees
Labels
brand `_brand.yml` documentation Doc improvements & quarto-web
Milestone

Comments

@gadenbuie
Copy link
Collaborator

What would you like to do?

Report an issue on quarto.org

Description

Originally pointed out here: posit-dev/brand-yml#56

The brand documentation at https://quarto.org/docs/authoring/brand.html should include information about how theme and brand interact, in particular to describe the difference between the following three scenarios:

format:
  html:
    theme: yeti

format:
  html:
    theme:
      - brand
      - yeti

format:
  html:
    theme:
      - yeti
      - brand
@gadenbuie gadenbuie added the documentation Doc improvements & quarto-web label Dec 2, 2024
@gadenbuie
Copy link
Collaborator Author

Oh, it is documented in More about Quarto themes, which is linked from the In SCSS section of the primary brand section.

I think the locations of those pieces make sense, but the core issue of how brand interacts with theme should probably be raised a little earlier in the docs. Many people will encounter needing to know about this without considering themselves among the category of users who needs to know about SCSS.

@mcanouil
Copy link
Collaborator

mcanouil commented Dec 2, 2024

I agree, at my first attempt at brand (last Thursday), I quickly needed to know this bit of information to properly use a default theme + brand.

I believe most of the brand users will already have a default theme set and will want to add branding to it.

@cscheid
Copy link
Collaborator

cscheid commented Dec 2, 2024

We changed the output of quarto create in 1.6 to have brand ahead of cosmo in the team, but I agree that we need to have a better explanation for folks migrating their <1.6 content.

@cscheid cscheid self-assigned this Dec 2, 2024
@cscheid cscheid added this to the Hot-fix milestone Dec 2, 2024
cscheid added a commit to quarto-dev/quarto-web that referenced this issue Dec 3, 2024
cscheid added a commit to quarto-dev/quarto-web that referenced this issue Dec 3, 2024
@cscheid cscheid closed this as completed Dec 3, 2024
github-actions bot pushed a commit to quarto-dev/quarto-web that referenced this issue Dec 3, 2024
(cherry picked from commit d0d743d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brand `_brand.yml` documentation Doc improvements & quarto-web
Projects
None yet
Development

No branches or pull requests

3 participants