Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#134: Change MD5 hash construction to avoid false-positives #139

Closed
wants to merge 7 commits into from
Closed

#134: Change MD5 hash construction to avoid false-positives #139

wants to merge 7 commits into from

Commits on Jul 23, 2021

  1. Change MD5 hash construction to avoid additional false-positives 

    Note that this will cause current transactions to become unique due to
the change in MD5 hash construction.
    Antlers committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    c2175ba View commit details
    Browse the repository at this point in the history

  2. Add '--depreciated-md5' option to allow skipping dupes via old hashes

    Antlers committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    237fd22 View commit details
    Browse the repository at this point in the history

  3. Remove set(): md5sum_hashes is already a set

    Antlers committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    2d0820e View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2021

  1. Update tests with new MD5's

    Antlers committed Jul 24, 2021
    Configuration menu
    Copy the full SHA
    114f758 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2021

  1. Add new test for '--depreciated-md5' 

    Includes a new transaction in transfer.csv, and a small header for
parsed_transfer.txt, which already wasn't the literal (ie. untouched)
result of parsing transfer.csv.
    Antlers committed Jul 25, 2021
    Configuration menu
    Copy the full SHA
    430f7a3 View commit details
    Browse the repository at this point in the history

  2. Remove redundant duplicated transaction 

    It doesn't look like this is used for anything, and the tests don't
fail without it, but correct me if I'm wrong ofc
    Antlers committed Jul 25, 2021
    Configuration menu
    Copy the full SHA
    302fbf6 View commit details
    Browse the repository at this point in the history

  3. Update README 

    A little trigger-happy with the force-pushes tonight..
EDIT: ..really trigger-happy, I just keeping seeing little things;
but I figure no-one's pulled or merged or looked at it yet.
    Antlers committed Jul 25, 2021
    Configuration menu
    Copy the full SHA
    f2cf133 View commit details
    Browse the repository at this point in the history