Use closefrom() to close open file descriptors #712
Merged
+21
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think so, it lives in unistd.h but it's hidden behind That said, I discovered musl doesn't have closefrom at all so I'd probably have to dlsym it or use a weak symbol. It'd be nice if something like this could be a simple change for once but we can't have that, can we? |
Replace the naive close() loop in js_os_exec with closefrom(). On my system RLIMIT_NOFILE is set to 1 million and the delay from the loop gets noticeable when I spawn many processes. Use dlsym() to look up closefrom() because it's not available everywhere (looking at you, musl.) Fixes: quickjs-ng#711
saghul
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the naive close() loop in js_os_exec with closefrom().
On my system RLIMIT_NOFILE is set to 1 million and the delay from the loop gets noticeable when I spawn many processes.
Fixes: #711