You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the proposal
In principle, we can build Quokka in a dimension-independent way, such that we don't need to set AMReX_SPACEDIM.
In practice, this will require setting AMReX_SPACEDIM=3 and then modifying the code to handle the case when Ny==1 and Nz==1 (for 1D sims) or when Nz==1 (for 2D sims) as special cases.
Describe alternatives you've considered
Keep the code as-is (re-build with different values of AMReX_SPACEDIM for different problems).
Describe the proposal
In principle, we can build Quokka in a dimension-independent way, such that we don't need to set
AMReX_SPACEDIM
.In practice, this will require setting
AMReX_SPACEDIM=3
and then modifying the code to handle the case whenNy==1
andNz==1
(for 1D sims) or whenNz==1
(for 2D sims) as special cases.Describe alternatives you've considered
Keep the code as-is (re-build with different values of AMReX_SPACEDIM for different problems).
Additional context
Some new features in AMReX may make the code changes easier: AMReX-Codes/amrex#4016.
See also: AMReX-Codes/amrex#3955
The text was updated successfully, but these errors were encountered: