Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 18787: Remove unnecessary code from glyphFont() #68

Open
5 tasks
hturner opened this issue Sep 30, 2024 · 0 comments
Open
5 tasks

Bug 18787: Remove unnecessary code from glyphFont() #68

hturner opened this issue Sep 30, 2024 · 0 comments
Labels
Graphics Issues related to graphics LatinR 2024 R Issue should require knowledge of R only

Comments

@hturner
Copy link
Member

hturner commented Sep 30, 2024 •
edited
Loading

As discussed in Bug 18787 R Core welcomes a patch for grDevices::glyphFont():

  • Modify glyphFont() so that it only produces a single font description.
  • Add some simple tests of the above to grDevices/tests/
  • May need clarifications within ?glyphFont
  • Regression test grid/tests/glyphs.R (including checks that output is unchanged, e.g., via {gdiff}).
  • Check that the changes do not break {marquee} (or change its output).

The file paths above refer to relative paths in the R sources, which you can browse on the r-svn GitHub mirror.
@hturner hturner added Graphics Issues related to graphics SIP 2024 Items reserved for R Dev Day @ SIP 2024 labels Sep 30, 2024
@hturner hturner added LatinR 2024 and removed SIP 2024 Items reserved for R Dev Day @ SIP 2024 labels Oct 16, 2024
@hturner hturner added the R Issue should require knowledge of R only label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Graphics Issues related to graphics LatinR 2024 R Issue should require knowledge of R only
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hturner