Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename as.*() → as_*() #49

Open
Tracked by #38
GegznaV opened this issue Aug 11, 2021 · 0 comments
Open
Tracked by #38

Rename as.*() → as_*() #49

GegznaV opened this issue Aug 11, 2021 · 0 comments
Labels
Topic: rename ♻️
Milestone
1.0 CRAN submission

Comments

@GegznaV
Copy link
Member

GegznaV commented Aug 11, 2021

I suggest renaming hyperSpec specific as.*() functions by replacing . with _

Current name Rename to Alternative Note
as.wide.df → as_wide_df as_df_wide() as_df_*() makes the 3 functions to have the same prefixed pattern
as.long.df → as_long_df as_df_long()
as.t.df → as_t_df as_df_t() what does t mean? Tall? Transposed? @cbeleites
as.hyperSpec → as_hyperSpec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Topic: rename ♻️
Projects
None yet
Milestone
1.0 CRAN submission
Development

No branches or pull requests
1 participant
@GegznaV