Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: could scales support keeping oob values but with infinites turned to NA? #429

Open
davidhodge931 opened this issue May 5, 2024 · 2 comments
Labels
feature a feature request or enhancement

Comments

@davidhodge931
Copy link

There is currently support of censor and squish with different treatment of Infinite values - but not for keep.

It'd be great if scales could support this.

This could work as a function e.g. oob_keep_finite.

Or alternatively add an infinite argument to oob_keep. However, this approach would be inconsistent with the approach taken with the others

@davidhodge931 davidhodge931 changed the title Feature request: Could scales support keeping oob values but with infinites turned to NA? Feature request: could scales support keeping oob values but with infinites turned to NA? May 5, 2024
@teunbrand
Copy link
Contributor

I'm not sure I understand what the function is supposed to do.
What should it return for c(-Inf, Inf, NaN, NA, 2)?

@davidhodge931
Copy link
Author

davidhodge931 commented May 5, 2024

I think c(NA, NA, NaN, NA, 2)
So it is keeping everything the same as oob_keep, but also converting Infinites to NA

@thomasp85 thomasp85 added the feature a feature request or enhancement label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

3 participants