-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't import sf and stars fully #894
Comments
Good point! For those using Internally, the vector-based shapes are internally stored as a list of simple features, and raster-based shapes as an empty stars object (data itself is in a data.table). The preprocessing is class-dependent: terra objects are preprocessed using native terra functions, sf using sf functions, etc. Perhaps we could use What are your ideas/opinions? |
Interesting! I was actually thinking of something simpler: I think that avoiding #' @import sf
#' @import stars seemed to decrease load time. (not done, since it could harm development workflow) but what I propose is Using #' @importFrom sf st_geometry sf_sf st_as_sf and namespacing calls with |
Done importFrom. Not sure if the loading time is less... |
Oh, it seems that you are right. I must have dreamt something yesterday! Feel free to revert if you find it a burden |
Possibly that prior to v4 release, could remove
tmap would potentially load faster?
I think it is fine to leave them for dev as it may be faster to iterate?
The text was updated successfully, but these errors were encountered: