feat(zora): update zora SDK and implement getFees #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4a180fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Fixes BOOST-4415 |
Quazia
approved these changes
Aug 13, 2024
| @@ -469,6 +439,17 @@ describe('simulateMint function', () => { | |||
| 'None of the specified function selectors are present in the contract bytecode.', | |||
| ) | |||
| }) | |||
|
|
|||
| test('should simulate a 1155 mint when tokenId using timed sale strategy', async () => { | |||
There was a problem hiding this comment.
V2 = timed sale strategy in all cases - right?
| expect(fee.actionFee).equals(parseEther('0.29')) | ||
| }) | ||
|
|
||
| test('should return the correct project + action fee for a 721 mint', async () => { |
There was a problem hiding this comment.
I haven't seen a 721 in a long time from Zora - they arn't running 721s really right? Have you seen a fixed sales strat with a 721?
There was a problem hiding this comment.
I have not seen an erc721 using the new sales strategy,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
salesConfigusing updated SDK.getFeesfunction for V2 mintsgetMintIntenttests. They are failing when not mocked due to the mins no longer being active.Fixes BOOST-4415