Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on invalid URIs #26

Open
eraffel-MDSol opened this issue Jul 5, 2024 · 0 comments
Open

Error on invalid URIs #26

eraffel-MDSol opened this issue Jul 5, 2024 · 0 comments

Comments

@eraffel-MDSol
Copy link

If a URI is not valid, calling escape here:

parts.map! { |p| p.split('=', 2).map!{ |s| unescape(s) } }

can throw an argument error:
https://github.com/ruby/ruby/blob/e5a195edf62fe1bf7146a191da13fa1c4fecbd71/lib/uri/common.rb#L398

Wondering if rack-cache should handle this in some way rather than bubbling it up through the middleware, or if there's a suggestion on how applications should do so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant