-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error on invalid URIs #26
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If a URI is not valid, calling escape here:
rack-cache/lib/rack/cache/key.rb
Line 61 in 5261d91
can throw an argument error:
https://github.com/ruby/ruby/blob/e5a195edf62fe1bf7146a191da13fa1c4fecbd71/lib/uri/common.rb#L398
Wondering if rack-cache should handle this in some way rather than bubbling it up through the middleware, or if there's a suggestion on how applications should do so
The text was updated successfully, but these errors were encountered: