-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synchronize search input with query #388
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
Could you please separate the PRs into two parts:
- Manual BBox entry
- Serarch input sync with query
I think we can more easily merge 1, but 2 is more difficult as it doesn't cater for all cases yet (queryables, collection search) and I fear that merging 2 in the current state will lead to bug reports that the sync is not complete.
@m-mohr - I updated this PR to just address the Search input sync with query, and I'll open the separate one for the BBoxEntry. I'll dig into the queryables and anything else I missed, as well. My intro to this browser didn't show the queryable portion, so I wasn't aware to be testing that out. |
Thanks. |
Thanks for the pointer. This was suggested to me as a good first task if I was able to learn some Vue. I'll dig into what you linked and see if I can make reasonable progress. |
Oh! The search box is a good one for "beginners" I guess, but the UI state for search is definitively a very complex issue I wouldn't recommend in this case. |
Fixes #302
This PR is intended to synchronize the filter options on the
/search
route with url parameters./search
route with URL parameters submits the formThe areaselect component doesn't handle passing in a pre-selected area. Without that, it was hard for a user to determine what the spatial extent in the search was. My route to solve this was to add a new BBEntry component that allows the entry of[x_min, y_min, x_max, y_max]
. If a shared url has spatial extent defined, then the bounding box selection will be here. The default behavior remains using the bounding box. This new component should also help accessibility, but a follow up task to update the areaSelect to accept an entry might be nice.