Merge pull request unoplatform#15208 from Youssef1313/build-perf

ci: Build performance improvements related to analyzers
ramezgerges · Jan 25, 2024 · 0effad5 · 0effad5
2 parents 73751af + 5abe5c3
commit 0effad5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/.globalconfig b/.globalconfig
@@ -142,6 +142,9 @@ dotnet_diagnostic.CA1309.severity = none
 # CA2101: Specify marshalling for P/Invoke string arguments
 dotnet_diagnostic.CA2101.severity = none
 
+# IDE0005: Remove unnecessary using directives
+dotnet_diagnostic.IDE0005.severity = none
+
 # IDE0055: Fix formatting
 dotnet_diagnostic.IDE0055.severity = warning # Will be promoted as an error by TreatWarningsAsErrors but also allows usage of WarningsNotAsErrors in debug
 

diff --git a/src/Uno.UI.RemoteControl.Host/Uno.UI.RemoteControl.Host.csproj b/src/Uno.UI.RemoteControl.Host/Uno.UI.RemoteControl.Host.csproj
@@ -20,6 +20,13 @@
 		<PackageReference Include="Microsoft.IO.RecyclableMemoryStream" Version="2.3.2" />
 		<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="7.0.0" />
 		<PackageReference Include="StreamJsonRpc" Version="2.14.24" />
+
+		<!-- StreamJsonRpc 2.14.24 brings in Microsoft.VisualStudio.Threading (and in turn -->
+		<!-- Microsoft.VisualStudio.Threading.Analyzers) version 17.1.46 -->
+		<!-- Analyzers version 17.1.46 has a performance issue that is fixed in 17.5.21 -->
+		<!-- commit: https://github.com/microsoft/vs-threading/commit/c7ceed01d1c73d7d5f2f6c0dd427245b3c7c8d96 -->
+		<!-- We explicitly add the reference here (same we do for Uno.UI.RemoteControl.VS.csproj) so we get a version with fast analyzers -->
+		<PackageReference Include="Microsoft.VisualStudio.Threading.Analyzers" Version="17.7.30" />
 	</ItemGroup>
 
 	<ItemGroup>