Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for embedded-registry RKE2 config #280

Closed
seif-raafat opened this issue Mar 8, 2024 · 1 comment
Closed

Add support for embedded-registry RKE2 config #280

seif-raafat opened this issue Mar 8, 2024 · 1 comment
Labels
kind/feature New feature or request lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-priority Indicates an issue or PR needs a priority assigning to it needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@seif-raafat
Copy link

Describe the solution you'd like:
Add a way to enable embedded-registry as part of the control plane config.yaml file. Even better would be to have a way to any add extra config for server/agent. This makes it easier to use RKE2 config as soon as they are released.

Why do you want this feature:
Currently, there is no clean way to use configuration that isn't in the RKE2ControlPlaneSpec or RKE2ConfigSpec.

Anything else you would like to add:
It would be good if the extra config gets parsed and merged with the rest of the config added in the spec.
@seif-raafat seif-raafat added kind/feature New feature or request needs-priority Indicates an issue or PR needs a priority assigning to it needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024

This issue is stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 7, 2024
@alexander-demicev alexander-demicev closed this as not planned Won't fix, can't repro, duplicate, stale Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature New feature or request lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-priority Indicates an issue or PR needs a priority assigning to it needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexander-demicev @seif-raafat