Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.9] Add "v26.0.x" option for "Docker Install URL" dropdown for RKE1 #10841

Closed
chiukapoor opened this issue Apr 19, 2024 · 8 comments
Closed
Assignees
Labels
ember Ember UI Issue kind/enhancement QA/manual-test Indicates issue requires manually testing size/1 Size Estimate 1
Milestone

Comments

@chiukapoor
Copy link

chiukapoor commented Apr 19, 2024

Is your feature request related to a problem? Please describe.
As part of rancher/rancher#45013 we're adding support for Docker 26.0.x.

Describe the solution you'd like
UI dropdowns that allow picking "Docker Install URL" (e.g. on Node Template details page - not sure where else it may be referenced) should additional have "v26.0 (Recommended)" choice that populates https://releases.rancher.com/install-docker/26.0.sh when selected.

Describe alternatives you've considered
Note "Docker Install URL" is editable and doesn't limit users to only the choices available, so they can specify https://releases.rancher.com/install-docker/26.0.sh manually as well before this enhancement is done.
Consequently existing option "v25.0.x (Recommended)" should be changed to "v25.0.x".

Additional Information

When a new version of the docker install is published, the UI will fetch that version and mark it as the default. Our role usually involves adding the previous version to the hard-coded list to serve as a cache.

See rancher/ui#5045 and rancher/ui#5136 for examples of how this has been previously handled.

@chiukapoor chiukapoor added this to the v2.9.next1 milestone Apr 19, 2024
@github-actions github-actions bot added [zube]: To Triage QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Apr 19, 2024
@richard-cox
Copy link
Member

@chiukapoor is this for 2.9.0, or afterwards?

@richard-cox
Copy link
Member

Similar to #10806

@chiukapoor
Copy link
Author

chiukapoor commented Apr 19, 2024

@chiukapoor is this for 2.9.0, or afterwards?

Yes, This is for v2.9.

@chiukapoor
Copy link
Author

Note: It needs to be handled only after backend changes are in.

@richard-cox richard-cox modified the milestones: v2.9.next1, v2.9.0 Apr 19, 2024
@rak-phillip
Copy link
Member

@richard-cox @chiukapoor does this need to be represented in v2.8-next1 as well?

@chiukapoor
Copy link
Author

@richard-cox @chiukapoor does this need to be represented in v2.8-next1 as well?

No, this is only for v2.9

@mitulshah-suse
Copy link

@richard-cox backend related work is completed. It is not blocked on backed anymore.

@gaktive gaktive added QA/manual-test Indicates issue requires manually testing size/1 Size Estimate 1 and removed QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels May 15, 2024
@nwmac nwmac added the ember Ember UI Issue label May 20, 2024
@nwmac nwmac self-assigned this May 20, 2024
@IsaSih IsaSih self-assigned this Jun 19, 2024
@IsaSih
Copy link

IsaSih commented Jun 19, 2024

test pass on v2.9-16190ecee0aa3fb4aa570aa0fc932a36d9dcd082-head

@IsaSih IsaSih closed this as completed Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ember Ember UI Issue kind/enhancement QA/manual-test Indicates issue requires manually testing size/1 Size Estimate 1
Projects
None yet
Development

No branches or pull requests

7 participants