Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to add kernel params #224

Closed
Tracked by #233
agracey opened this issue Jul 29, 2022 · 5 comments
Closed
Tracked by #233

Document how to add kernel params #224

agracey opened this issue Jul 29, 2022 · 5 comments
Assignees
Labels
kind/documentation Improvements or additions to documentation

Comments

@agracey
Copy link

agracey commented Jul 29, 2022

It would be nice to have it documented how to change the kernel params for a system both before installation (via MachineRegistraion) as well on an existing system.

@agracey
Copy link
Author

agracey commented Jul 29, 2022

Editing on a running system is less important as any kernel params should be known in advanced but mistakes happen so it would be nice to not require re-imaging

@kkaempf kkaempf added the kind/documentation Improvements or additions to documentation label Jul 29, 2022
@Itxaka
Copy link
Contributor

Itxaka commented Aug 1, 2022

I think this is covered by https://rancher.github.io/elemental-toolkit/docs/customizing/configure_grub/ and https://rancher.github.io/elemental-toolkit/docs/customizing/runtime_persistent_changes/

Before installation (The iso boot params) I dont think its possible unless you create your own derivative as we ship a default bootargs.cfg that contains the default kernel params from elemental-toolkit.

@kkaempf
Copy link
Contributor

kkaempf commented Aug 1, 2022

Not sure it the elemental-toolkit is the best place for it. The current node-image doesn't use elemental-toolkit at all. 🤔

Does the "elemental" documentation link to the "elemental-toolkit" docs ?

@Itxaka
Copy link
Contributor

Itxaka commented Aug 2, 2022

Doesnt use any scripts from cos-toolkit? Where does the inmutability comes from? Where does the grub stuff comes from? Its all from the toolkit, and you can get the persistence enabled for root by setting the params provided in those docs.

Not that I dont agree with this, we dont have a proper way of passing extra cloud-configs or other args properly currently. But this card is about docs more than implementation. Implementation wise it probably requires some changes to how we consume, but we can currently do what is asked by following the docs.

See how c3os does it via cloud-init: https://github.com/c3os-io/c3os/blob/master/overlay/files/system/oem/21_grub.yaml

@mjura mjura self-assigned this Aug 30, 2022
@kkaempf
Copy link
Contributor

kkaempf commented Sep 20, 2022

Closing as of #224 (comment)
Follow up: rancher/elemental-toolkit#1773

@kkaempf kkaempf closed this as completed Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Improvements or additions to documentation
Projects
Archived in project
Development

No branches or pull requests

4 participants