Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of media-bundle 2.0, add support for Symfony 7 #11

Open
tacman opened this issue Sep 30, 2023 · 7 comments
Open

Status of media-bundle 2.0, add support for Symfony 7 #11

tacman opened this issue Sep 30, 2023 · 7 comments

Comments

@tacman
Copy link
Contributor

tacman commented Sep 30, 2023

I noticed that there's a media-bundle 2.0 beta branch, what's the status of this?

Also, since it's a new release, what do you think of upgrading the dependencies to Symfony ^6.3 || ^7 and PHP 8.1?

Symfony 7 will be out in less than 2 months, so it seems like that might be a good goal for media-bundle 2.0 as well.

@chiqui3d
Copy link
Contributor

Sorry, I've been busy, but I'll get back to you tomorrow with the compatibilities and other bugs I've seen. Branch 2, which aims to add support for different storage, is going to take some more time, once I finish the changes mentioned above

@tacman
Copy link
Contributor Author

tacman commented Dec 23, 2023 via email

@chiqui3d
Copy link
Contributor

No, I don't have a demo repository yet, I hope to do it soon with EasyAdmin, I hope this release https://github.com/ranky/media-bundle/releases/tag/v1.4.0 fixes the compatibility with Symfony 7

@tacman
Copy link
Contributor Author

tacman commented Dec 29, 2023

Eh, I don't love EasyAdmin for demos, although maybe that won't be too important. I'm more interested in seeing the entity configuration. Since this bundle already has it's own media management, is EasyAdmin necessary?

Speaking of your own management page, consider dropping webpack and using AssetMapper instead for the demo. Then you can get rid of the

  {{ encore_entry_link_tags('ranky_media', null, 'ranky_media') }}

AssetMapper is awesome. No build step. And combined with stimulus and TwigComponents, I'm able to hide away most of my javascript.

@chiqui3d
Copy link
Contributor

No, EasyAdmin is not necessary, I can use the Symfony demo, even simpler. Yes, I will try to use AssetMapper in the future.

@tacman
Copy link
Contributor Author

tacman commented Dec 29, 2023 via email

@tacman
Copy link
Contributor Author

tacman commented Jan 3, 2024

Any status on a demo? I've been contributing to the version 3 branch of LiipImagineBundle, and wanted a demo repo to work with, and of course thought of this bundle, they should pair nicely together.

On a related note, intervention/image is at v2, which is at EOL, and should be updated to v3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants