Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add behavior change notices to NATIVE #317

Open
Tracked by #318
robertmaynard opened this issue Dec 1, 2022 · 3 comments
Open
Tracked by #318

Add behavior change notices to NATIVE #317

robertmaynard opened this issue Dec 1, 2022 · 3 comments
Labels
feature request New feature or request

Comments

@robertmaynard
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We want to announce behavior changes coming of the NATIVE case of CMAKE_CUDA_ARCHITECTURES from rapids-cmake.

Describe the solution you'd like
Unlike #316 the swtich from NATIVE to native does have an observable side-effect on the project. The rapids-cmake NATIVE resolves down to the actual architecture value ( 75-real ) after the project() call, while native stays native as now nvcc supports flags like -arch=native.

What we want to do for 22.03 is add a behavior notice to rapids-cmake that NATIVE will map to native starting in 23.04.

@robertmaynard
Copy link
Contributor Author

The behavior change should also state that NATIVE will be removed in 23.06

@robertmaynard robertmaynard changed the title [FEA] Add behavior change notices to NATIVE Add behavior change notices to NATIVE Dec 1, 2022
@robertmaynard robertmaynard changed the title Add behavior change notices to NATIVE Add behavior change notices to NATIVE and "" Dec 1, 2022
@robertmaynard robertmaynard changed the title Add behavior change notices to NATIVE and "" Add behavior change notices to NATIVE Dec 1, 2022
@robertmaynard
Copy link
Contributor Author

Also remember to incldue "" in the behavior change / deprecation notice

@robertmaynard
Copy link
Contributor Author

Was thinking about this again and wanted to measure the performance cost of using -arch=native compared to what rapids-cmake does.

For libcudf total compile times at -j20 go from 8min 42sec to 8min 44sec so basically noise. We shouldn't consider performance of -arch=native to a issue when switching rapids-cmake NATIVE over to native.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant