Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QST] Implement consistent usage of rapids_cmake_support_conda_env #334

Open
vyasr opened this issue Dec 21, 2022 · 3 comments
Open

[QST] Implement consistent usage of rapids_cmake_support_conda_env #334

vyasr opened this issue Dec 21, 2022 · 3 comments
Labels
? - Needs Triage Need team to review and classify question Further information is requested

Comments

@vyasr
Copy link
Contributor

vyasr commented Dec 21, 2022

What is your question?

This isn't strictly a question about rapids-cmake so much as a question about its usage across RAPIDS, but there isn't a great place to raise this question so sticking it here for now. Right now it looks like only cuML and raft use this functionality, but I assume we want to handle it consistently in all packages.

@vyasr vyasr added question Further information is requested ? - Needs Triage Need team to review and classify labels Dec 21, 2022
@robertmaynard
Copy link
Contributor

You mean the python side of cudf correct ? since libcudf does call rapids_cmake_support_conda_env ( https://github.com/rapidsai/cudf/blob/branch-23.02/cpp/CMakeLists.txt#L127 )

@vyasr
Copy link
Contributor Author

vyasr commented Jan 4, 2023

You're right that libcudf uses it, although it does so a bit differently since both cuml and raft both support configuring whether it's called using the DETECT_CONDA_ENV option and they also support the environment variable CONDA_PREFIX. There's no good reason I can think of why that sort of behavior shouldn't be standardized across all the lib* CMake.

And then yes, figuring out what if anything we should be doing on the Python side.

@robertmaynard
Copy link
Contributor

I agree on standardization behavior around conda env detection and behavior.

On that front I am not a fan of the behavior the some projects have where they change the CMAKE_INSTALL_PREFIX when using conda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify question Further information is requested
Projects
Status: No status
Development

No branches or pull requests

2 participants