Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] rapids-cmake GLOBAL_TARGETS .... should just infer CMAKE_FIND_PACKAGE_TARGETS_GLOBAL=ON #626

Open
robertmaynard opened this issue Jun 5, 2024 · 0 comments
Open

[FEA] rapids-cmake GLOBAL_TARGETS .... should just infer CMAKE_FIND_PACKAGE_TARGETS_GLOBAL=ON #626

robertmaynard opened this issue Jun 5, 2024 · 0 comments
Labels
? - Needs Triage Need team to review and classify feature request New feature or request

Comments

@robertmaynard
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently developers need to explicitly list the targets they want evalated to global state. Now that we require CMake 3.24 we should
remove that burden of listing targets from users of rapids-cmake.

Describe the solution you'd like

Every rapids-cmake API that has a GLOBAL_TARGETS parameter should support zero values.
When we are given GLOBAL_TARGETS we should enable CMAKE_FIND_PACKAGE_TARGETS_GLOBAL to make all targets global and not just the ones listed.
@robertmaynard robertmaynard added feature request New feature or request ? - Needs Triage Need team to review and classify labels Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
? - Needs Triage Need team to review and classify feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robertmaynard