Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] rapids_test_install_relocatable() does not play nice with gtest_discover_tests(DISCOVERY_MODE PRE_TEST) #690

Closed
Jacobfaib opened this issue Sep 15, 2024 · 1 comment · Fixed by #697
Assignees
Labels
2 - In Progress Currenty a work in progress bug Something isn't working

Comments

@Jacobfaib
Copy link
Contributor

Full description of the bug can be found here: https://gitlab.kitware.com/cmake/cmake/-/issues/26294 (specifically https://gitlab.kitware.com/cmake/cmake/-/issues/26294#note_1568638)...

...but the TL;DR is that the CTestInstall.cmake rewriting done by rapids_test_install_relocatable() eventually leads to include()-ing GoogleTestAddTests.cmake. This module -- if called in scripting mode (which it will be at install-time) -- will attempt to call a function which expects certain variables to be predefined. These variables are not defined, and hence install errors out.

@Jacobfaib Jacobfaib added ? - Needs Triage Need team to review and classify bug Something isn't working labels Sep 15, 2024
@robertmaynard
Copy link
Contributor

rapids_test_install_relocatable only supports installing and running tests added by rapids_test_add. You can't install tests added via gtest_discover_tests as those aren't known when the install step is run.

We should be able to update rapids_test_install_relocatable to work around the issue of mixing gtest_discover_tests and rapids-cmake tests, but your installed test set will not include any of the tests found by gtest_discover_tests

@robertmaynard robertmaynard added 2 - In Progress Currenty a work in progress and removed ? - Needs Triage Need team to review and classify labels Oct 1, 2024
@robertmaynard robertmaynard self-assigned this Oct 1, 2024
@rapids-bot rapids-bot bot closed this as completed in #697 Oct 7, 2024
@rapids-bot rapids-bot bot closed this as completed in 7879f97 Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - In Progress Currenty a work in progress bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants