Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isw #89

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Add isw #89

merged 2 commits into from
Sep 25, 2024

Conversation

thom-cameron
Copy link
Contributor

Added the terminal stopwatch application I recently created, isw.

See the GitLab repository here:
https://gitlab.com/thom-cameron/isw

@thom-cameron
Copy link
Contributor Author

The linter doesn't seem to like the double period at "etc.." but I think it's correct as it is. The first mark shows that the word is abbreviated, while the second ends the sentence. Open to changing it if someone else feels differently though.

@orhun
Copy link
Member

orhun commented Sep 25, 2024

Let's go with a single dot if it is not a big deal :)

@orhun orhun merged commit 63dbc52 into ratatui:main Sep 25, 2024
3 checks passed
@thom-cameron thom-cameron deleted the patch-1 branch September 25, 2024 09:29
@joshka
Copy link
Member

joshka commented Sep 25, 2024

The linter doesn't seem to like the double period at "etc.." but I think it's correct as it is. The first mark shows that the word is abbreviated, while the second ends the sentence. Open to changing it if someone else feels differently though.

I was curious about the double period because I have often not known the rule for how to handle them. The Chicago Manual of style FAQs suggest a single period is right to use unless it's in parenthesis. https://www.chicagomanualofstyle.org/qanda/data/faq/topics/Punctuation/faq0116.html

I'm sure there's probably other style guides that could differ in their advice for this, but CMOS seems to be one of the more influential guides to adhere to, so definitely this falls in the good enough bucket.

@thom-cameron
Copy link
Contributor Author

Interesting, I didn't know there was a specific rule for that, thanks. English never ceases to amaze with the number it has.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants