Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Notify user who made commit #72

Open
niels-bosman opened this issue Oct 14, 2022 · 8 comments
Open

Feature request: Notify user who made commit #72

niels-bosman opened this issue Oct 14, 2022 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@niels-bosman
Copy link

Right now you can notify slack users for when the pipeline fails, would be nice if there was an option to map the GitHub users with the Slack username so only the person committing get's tagged in the message.

@ravsam-bot
Copy link
Contributor

ravsam-bot bot commented Oct 14, 2022

Hello and welcome to RavSam 💜. Thanks for opening your first issue. I will assign one of our team members to take a look at the problem you have raised. Make sure to include as much information as possible to help our team diagnose the issue and solve it quickly.

If the problem is related to a security concern, then please delete this issue and send us an email at info@ravsam.in.

@ravgeetdhillon ravgeetdhillon added the enhancement New feature or request label Oct 16, 2022
@rdhar
Copy link

rdhar commented Oct 19, 2022

Related to #31.

@ravgeetdhillon
Copy link
Member

ravgeetdhillon commented Oct 19, 2022

@niels-bosman @rdhar Do you have any suggestions on how you would like this to be implemented from the end user perspective? What would be the format of the input that you would provide?

@rdhar
Copy link

rdhar commented Oct 20, 2022

To be honest, I'm not sure that a seamless implementation is possible between Slack user-mentions and GitHub username due to potential mismatch between user handles. That being said, I went through some of the most popular GitHub Action integration for Slack notifications to find a common theme:

Taking this into account, perhaps a new variable can be introduced to use GITHUB_ACTOR to notify in Slack.

@niels-bosman
Copy link
Author

@ravgeetdhillon @rdhar I think it should be easy for users to enable this behaviour. The more complex logic should be dealt with by the package itself. Something like this:

steps:
  - uses: ravsamhq/notify-slack-action@v2
    if: always()
    with:
      status: ${{ job.status }}
      notify_actor: true # The new field
    env:
      SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} # required

@ogind-bdhavale
Copy link

I am also facing similar issue. I am sending notification to slack channel and I want to mention user who has merged the PR or did the commit. The user is already part of slack channel.
The slack user name can be fetched by mapping of GitHub user email address and slack user email address.

@fede843
Copy link

fede843 commented Mar 8, 2023

+1

@jfoley15
Copy link

Also would love this enhancement.

@niels-bosman @rdhar Do you have any suggestions on how you would like this to be implemented from the end user perspective? What would be the format of the input that you would provide?

The input mention_users: "U0160UUNH8S,U0080UUAA9N" being able to accept other forms of id such as email address (available from the GitHub context) would be nice and easy for the end user imo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants