From 5c2fba0f94d21773f8dd7ef996254f56fd9ee64e Mon Sep 17 00:00:00 2001 From: Qing Wang Date: Tue, 11 Jul 2023 11:40:55 +0800 Subject: [PATCH] Address comments. Signed-off-by: Qing Wang --- fed/_private/fed_call_holder.py | 2 +- fed/api.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/fed/_private/fed_call_holder.py b/fed/_private/fed_call_holder.py index 0773901..1fc339e 100644 --- a/fed/_private/fed_call_holder.py +++ b/fed/_private/fed_call_holder.py @@ -56,7 +56,7 @@ def options(self, **options): return self def internal_remote(self, *args, **kwargs): - if self._node_party is None or len(self._node_party) == 0: + if not self._node_party: raise ValueError("You should specify a party name on the fed actor.") # Generate a new fed task id for this call. diff --git a/fed/api.py b/fed/api.py index 8548c5f..460fbde 100644 --- a/fed/api.py +++ b/fed/api.py @@ -300,9 +300,9 @@ def options(self, **options): return self def remote(self, *args, **kwargs): - assert ( - self._node_party is not None - ), "A fed function should be specified within a party to execute." + if not self._node_party: + raise ValueError("You should specify a party name on the fed function.") + return self._fed_call_holder.internal_remote(*args, **kwargs) def _execute_impl(self, args, kwargs):