Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's the meaning of the "cluster_config" ? #156

Open
NKcqx opened this issue Jul 18, 2023 · 4 comments
Open

What's the meaning of the "cluster_config" ? #156

NKcqx opened this issue Jul 18, 2023 · 4 comments
Assignees
Labels
question Further information is requested

Comments

@NKcqx
Copy link
Collaborator

NKcqx commented Jul 18, 2023

          Now that we separate `ray.init` from `fed.init`,  there's no way to reach the cluster-level information, since each `fed.init` starts and only starts a job session.

Unless there's a global actor (or service job) that can break the job isolation and filter each job's tasks' invalid param type.

Originally posted by @NKcqx in #140 (comment)

@NKcqx
Copy link
Collaborator Author

NKcqx commented Jul 18, 2023

          If we don't have the cluster config, why we not just use `config`? The question that we should answer before it getting finalized is whether we need the cluster config in the future at high level.

Originally posted by @jovany-wang in #140 (comment)

@NKcqx
Copy link
Collaborator Author

NKcqx commented Jul 18, 2023

Firstly, the fact is that user can't configure the Ray cluster in a rayfed job, since the initialization of Ray cluster has separated from RayFed, i.e. fed.init.
I think the original semantic of "cluster_config" is "configure the cluster used in this job", in which case, it's a job-level config but containing all the non-business configurations.

@jovany-wang
Copy link
Collaborator

I think the original semantic of "cluster_config" is "configure the cluster used in this job", in which case, it's a job-level config but containing all the non-business configurations.

It sounds reasonable. Let's use the config key word as the job level configurations parameter name.

@jovany-wang
Copy link
Collaborator

What's the status of this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants