Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omniauth-foursquare isn't compliant with the auth hash schema #18

Open
romanbsd opened this issue Jun 9, 2014 · 0 comments
Open

omniauth-foursquare isn't compliant with the auth hash schema #18

romanbsd opened this issue Jun 9, 2014 · 0 comments

Comments

@romanbsd
Copy link

romanbsd commented Jun 9, 2014

Based upon the omniauth wiki -
https://github.com/intridea/omniauth/wiki/Auth-Hash-Schema

The image should be "A URL representing a profile image of the authenticating user. Where possible, should be specified to a square, roughly 50x50 pixel image.", however in case on omniauth-foursquare it's a hash.

In my projects I do something like this in order to normalize it (50x50 was proven to be to small for me):

image =  [image['prefix'], '100x100', image['suffix']].join

I think that it's a sensible approach to return a URL for info.image, and put this has in the 'extra' hash (if it's not there already).

@romanbsd romanbsd changed the title omniauth-foursquare isn't compliant with auth hash schema omniauth-foursquare isn't compliant with the auth hash schema Jun 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant