Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the following icons to set of blade icons #1235

Closed
prabhasjoshi opened this issue May 31, 2023 · 8 comments
Closed

Add the following icons to set of blade icons #1235

prabhasjoshi opened this issue May 31, 2023 · 8 comments
Assignees
Labels
🔍 Needs clarification Needs clarification from the issue author P1 Kinda Important

Comments

@prabhasjoshi
Copy link

prabhasjoshi commented May 31, 2023

There are certain icons which are not currently available in blade icon. Request to get them added [still a wip - this is an unexhaustive list - will confirm and remove this comment]

  1. Wallet
image
  1. UPI Icon
image
  1. A titla
image
  1. Netbanking
image This icon is slightly different from the BankIcon present currently
  1. Question mark icon
image
  1. Icon for Zoho:
image
@anuraghazra
Copy link
Member

anuraghazra commented May 31, 2023

Are these icons from X?
@prabhasjoshi can you once get this confirmed with your designer & with rastogi. We should add them on design side first. Maybe start a slack thread.

@saurav12 ^

@prabhasjoshi
Copy link
Author

@anuraghazra yes these are from x - will be adding a large set of icons (which can be vectorised) to this list - it's still not complete.
once complete - will start the thread

@saurav12
Copy link
Member

Yeah, please let's get this started on design first. Also, @prabhasjoshi let me know who is the POC for this from the design side.

@prabhasjoshi
Copy link
Author

@saurav12 will let you know about this.
will have to ask x- design and complete the list which x icons have which are not in blade.

@divyanshu013
Copy link
Contributor

divyanshu013 commented Jun 1, 2023

Once we've these on design we can run the icons import script to sync them on Blade

@divyanshu013 divyanshu013 added the P1 Kinda Important label Jun 1, 2023
@chaitanyadeorukhkar
Copy link
Collaborator

@prabhasjoshi any update on this?

@chaitanyadeorukhkar chaitanyadeorukhkar added the 🔍 Needs clarification Needs clarification from the issue author label Jul 14, 2023
@pritipsingh
Copy link
Contributor

Hey @prabhasjoshi can I take this up if it's open?

@saurabhdaware
Copy link
Member

Hi @pritipsingh, this needs to be discussed among our design team before being picked. Maybe you can take a look at other open issues and see if you find something interesting?

I'll close this issue for now. We now have a script to sync design icons with dev once they are added in figma.

We have #1098 to track adding our script to github from local so don't think so this issue is needed anymore as once we add script, and add icons to figma, all icons from figma will be synced with code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔍 Needs clarification Needs clarification from the issue author P1 Kinda Important
Projects
None yet
Development

No branches or pull requests

7 participants