Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list variable names in DocumentDefinitionHelper #45

Open
piehld opened this issue Apr 25, 2022 · 0 comments
Open

Fix list variable names in DocumentDefinitionHelper #45

piehld opened this issue Apr 25, 2022 · 0 comments
Assignees

Comments

@piehld
Copy link
Collaborator

piehld commented Apr 25, 2022

Notice the incorrect naming of the includeL and excludeL variables in DocumentDefinitionHelper (here). The names should be flip-flopped between the two methods:

    def getExcluded(self, collectionName):
        """For input collection, return the list of excluded schema identifiers."""
        includeL = []
        try:
            includeL = [tS.upper() for tS in self.__cfgD["document_collection_content_filters"][collectionName]["EXCLUDE"]]
        except Exception as e:
            logger.debug("Collection %s failing with %s", collectionName, str(e))
        return includeL

    def getIncluded(self, collectionName):
        """For input collection, return the list of included schema identifiers."""
        excludeL = []
        try:
            excludeL = [tS.upper() for tS in self.__cfgD["document_collection_content_filters"][collectionName]["INCLUDE"]]
        except Exception as e:
            logger.debug("Collection %s failing with %s", collectionName, str(e))
        return excludeL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants