Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utility Function "isempty" is a Freak Creature #552

Open
rdbyk opened this issue May 24, 2018 · 0 comments
Open

Utility Function "isempty" is a Freak Creature #552

rdbyk opened this issue May 24, 2018 · 0 comments

Comments

@rdbyk
Copy link
Owner

rdbyk commented May 24, 2018

  1. help page of isempty tells not the whole truth, there are some questionable hidden features (cf. here)
  2. in theory isempty should be a very simple and basic utility, but in reality it is really slow, and sadly it is used quite a lot in the code base
  3. don't expect C API function scilab_isEmpty to behave like isempty, it is not.
  4. undcoumented bells and whistles of isempty are rendering code intransparent

Proposal:

  1. rename isempty to isevil (just kidding)
  2. avoid all evil and stay with the good forces ..., i.e. for the time being don't use isevil at all
  3. in the long run, one may replace isevil by a new, efficent, and simply defined isempty utility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant