Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The target prop should be optional in the TypeScript type definition #972

Open
coryhouse opened this issue Aug 21, 2021 · 0 comments
Open

Comments

@coryhouse
Copy link

coryhouse commented Aug 21, 2021

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch react-overlays@5.1.1 for the project I'm working on.

Per the docs, the target prop should be optional. But TypeScript is requiring it.

Here is the diff that solved my problem:

diff --git a/node_modules/react-overlays/esm/Overlay.d.ts b/node_modules/react-overlays/esm/Overlay.d.ts
index 2a06425..ee42e82 100644
--- a/node_modules/react-overlays/esm/Overlay.d.ts
+++ b/node_modules/react-overlays/esm/Overlay.d.ts
@@ -10,7 +10,7 @@ export interface OverlayProps extends TransitionCallbacks {
     containerPadding?: number;
     popperConfig?: Omit<UsePopperOptions, 'placement'>;
     container?: DOMContainer;
-    target: DOMContainer;
+    target?: DOMContainer;
     show?: boolean;
     transition?: React.ComponentType<{
         in?: boolean;

This issue body was partially generated by patch-package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant