Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jupyter Notebook output #124

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

avsm
Copy link
Member

@avsm avsm commented Apr 14, 2019

This is a WIP; creating a PR to make it easy for @jonludlam and me to push to our forks

  • detect and reject multiple environments in one notebook (or figure out how to make them work in Jupyter)

@avsm
Copy link
Member Author

avsm commented Sep 13, 2019

Some quality of life improvements: supports Markdown sections and raw cells now

@avsm
Copy link
Member Author

avsm commented Sep 21, 2019

Noticed a problem that causes divergence between mdx evaluation and Jupyter. The latter doesn't support multiple environments, so having two OCaml environments will cause them to be silently merged into one with the PR.

@gpetiot
Copy link
Contributor

gpetiot commented Aug 27, 2020

Hi, should I revive this PR or is the environment issue something that will prevent it from working at all?

@craigfe
Copy link
Contributor

craigfe commented Sep 3, 2020

I have a rebased form of this PR at CraigFe/jupyter if you do decide to go ahead with this.

@avsm
Copy link
Member Author

avsm commented Sep 3, 2020

thanks, I've pushed your rebase here. @NathanReb we could go ahead with merging this; the only restriction it would be nice to have before that is to ensure that there is only one environment per notebook.

@craigfe
Copy link
Contributor

craigfe commented Sep 9, 2020

From playing around with this PR, I noticed that it doesn't yet support file includes. I have a fairly hacky patch for that here, but it probably warrants a cleaner implementation (that doesn't just fail for a large number of block types).

@avsm
Copy link
Member Author

avsm commented Nov 19, 2020

Could we get this merged as an experimental feature @gpetiot, so that @craigfe's variant above can be tracked? It's already useful as-is despite the limitations.

@NathanReb NathanReb changed the base branch from master to main July 2, 2021 09:47
@avsm
Copy link
Member Author

avsm commented Sep 16, 2021

rebased to current trunk

@gpetiot gpetiot force-pushed the jupyter branch 4 times, most recently from 4338055 to c29c5ba Compare September 28, 2021 13:58
@gpetiot
Copy link
Contributor

gpetiot commented Sep 28, 2021

I rebased, cleaned up and added a test

@gpetiot gpetiot changed the title add Jupyter output Add Jupyter Notebook output Sep 28, 2021
@avsm avsm marked this pull request as ready for review October 15, 2021 12:03
Signed-off-by: Jon Ludlam <jon@recoil.org>
Coauthored-by: Anil Madhavapeddy <anil@recoil.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants