Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: SHARED_VOLUME_PATH not dynamically configurable #217

Open
diegodelemos opened this issue Oct 12, 2020 · 1 comment · Fixed by reanahub/pytest-reana#66
Open

tests: SHARED_VOLUME_PATH not dynamically configurable #217

diegodelemos opened this issue Oct 12, 2020 · 1 comment · Fixed by reanahub/pytest-reana#66
Assignees
@diegodelemos
Labels
type/bug Something isn't working
Projects
User-Quotas

Comments

@diegodelemos
Copy link
Member

Currently, any component that uses REANA-Commons will have have failing tests e.g. this build in RWC, because of:

...
fs.errors.CreateFailed: root path '/var/reana' does not exist
...

This happens because even though we create a temporary directory and then we configure the Flask app to take it into account in tests, the SHARED_VOLUME_PATH inside REANA-Commons remains unchanged and REANA-Commons's get_disk_usage relies on it directly.

Possible solutions:

  1. Configure SHARED_VOLUME_PATH through environment variable
  2. Pass the root path from outside get_disk_usage as new parameter. This way it would be the responsibility of the clients to load dynamic config (e.g. RWC)
  3. Centralise REANA config loading so it can be easily patched for tests (connected to Ease extension of REANA configuration reana#277)
@diegodelemos diegodelemos added the type/bug Something isn't working label Oct 12, 2020
@diegodelemos diegodelemos self-assigned this Oct 12, 2020
@diegodelemos diegodelemos added this to In work in User-Quotas Oct 12, 2020
diegodelemos pushed a commit to diegodelemos/pytest-reana that referenced this issue Oct 13, 2020
fixtures: SHARED_VOLUME_PATH through env variable
4be38bb 
* Addresses reanahub/reana-commons#217.
diegodelemos pushed a commit to diegodelemos/pytest-reana that referenced this issue Oct 13, 2020
fixtures: SHARED_VOLUME_PATH through env variable
cfa3e9e 
* Addresses reanahub/reana-commons#217.
diegodelemos pushed a commit to diegodelemos/pytest-reana that referenced this issue Oct 13, 2020
fixtures: shared volume path through env variable
64debd4 
* Addresses reanahub/reana-commons#217.
diegodelemos pushed a commit to diegodelemos/pytest-reana that referenced this issue Oct 13, 2020
fixtures: shared volume path through env variable
b04c576 
* Addresses reanahub/reana-commons#217.
diegodelemos pushed a commit to diegodelemos/pytest-reana that referenced this issue Oct 13, 2020
fixtures: shared volume path through env variable
e38a99f 
* Addresses reanahub/reana-commons#217.
diegodelemos pushed a commit to diegodelemos/pytest-reana that referenced this issue Oct 13, 2020
fixtures: shared volume path through env variable
dbd3c61 
* Addresses reanahub/reana-commons#217.
diegodelemos pushed a commit to diegodelemos/reana-workflow-controller that referenced this issue Oct 13, 2020
tests: update to latest pytest-reana
a12dc29 
* Uses latest pytes-reana which allows configuring the
  `tmp_shared_volume_path` fixture through environment variable
  which is needed because of reanahub/reana-commons#217.

* Amends test according to latest changes.
diegodelemos pushed a commit to diegodelemos/reana-workflow-controller that referenced this issue Oct 13, 2020
tests: update to latest pytest-reana
97f0a9f 
* Uses latest pytes-reana which allows configuring the
  `tmp_shared_volume_path` fixture through environment variable
  which is needed because of reanahub/reana-commons#217.

* Amends test according to latest changes.
diegodelemos pushed a commit to diegodelemos/reana-workflow-controller that referenced this issue Oct 13, 2020
tests: update to latest pytest-reana
0366839 
* Uses latest pytes-reana which allows configuring the
  `tmp_shared_volume_path` fixture through environment variable
  which is needed because of reanahub/reana-commons#217.

* Amends test according to latest changes.
diegodelemos pushed a commit to diegodelemos/reana-workflow-controller that referenced this issue Oct 13, 2020
tests: configure SHARED_VOLUME_PATH in Travis
b6db250 
* Uses latest pytes-reana which allows configuring the
  `tmp_shared_volume_path` fixture through environment variable
  which is needed because of reanahub/reana-commons#217.

* Amends test according to latest changes.
diegodelemos pushed a commit to diegodelemos/reana-workflow-controller that referenced this issue Oct 13, 2020
tests: configure SHARED_VOLUME_PATH in Travis
ec6ad79 
* Uses latest pytes-reana which allows configuring the
  `tmp_shared_volume_path` fixture through environment variable
  which is needed because of reanahub/reana-commons#217.

* Amends test according to latest changes.
diegodelemos pushed a commit to audrium/reana-workflow-controller that referenced this issue Oct 13, 2020
tests: configure SHARED_VOLUME_PATH in Travis
bf73b32 
* Uses latest pytes-reana which allows configuring the
  `tmp_shared_volume_path` fixture through environment variable
  which is needed because of reanahub/reana-commons#217.

* Amends test according to latest changes.
diegodelemos pushed a commit to diegodelemos/reana-workflow-controller that referenced this issue Oct 13, 2020
tests: configure SHARED_VOLUME_PATH in Travis
dcb13d1 
* Uses latest pytes-reana which allows configuring the
  `tmp_shared_volume_path` fixture through environment variable
  which is needed because of reanahub/reana-commons#217.

* Amends test according to latest changes.
diegodelemos pushed a commit to audrium/reana-workflow-controller that referenced this issue Oct 14, 2020
tests: configure SHARED_VOLUME_PATH in Travis
b7a0917 
* Uses latest pytes-reana which allows configuring the
  `tmp_shared_volume_path` fixture through environment variable
  which is needed because of reanahub/reana-commons#217.

* Amends test according to latest changes.
@diegodelemos diegodelemos mentioned this issue Oct 14, 2020
Merged
@diegodelemos diegodelemos moved this from In work to In review in User-Quotas Oct 14, 2020
User-Quotas automation moved this from In review to Done Oct 15, 2020
diegodelemos pushed a commit to audrium/reana-workflow-controller that referenced this issue Oct 15, 2020
tests: configure SHARED_VOLUME_PATH in Travis
2c87ee8 
* Uses latest pytes-reana which allows configuring the
  `tmp_shared_volume_path` fixture through environment variable
  which is needed because of reanahub/reana-commons#217.

* Amends test according to latest changes.
diegodelemos pushed a commit to audrium/reana-workflow-controller that referenced this issue Oct 15, 2020
tests: configure SHARED_VOLUME_PATH in Travis
c9dc85e 
* Uses latest pytes-reana which allows configuring the
  `tmp_shared_volume_path` fixture through environment variable
  which is needed because of reanahub/reana-commons#217.

* Amends test according to latest changes.
diegodelemos pushed a commit to diegodelemos/reana-workflow-controller that referenced this issue Oct 30, 2020
ci: set SHARED_VOLUME_PATH for tests to work
3fa50c1 
* Reverting this change as it was fixing
  reanahub/reana-commons#217.
diegodelemos pushed a commit to diegodelemos/reana-workflow-controller that referenced this issue Oct 30, 2020
ci: set SHARED_VOLUME_PATH for tests to work
4701718 
* Reverting this change as it was fixing
  reanahub/reana-commons#217.
@diegodelemos
Copy link
Member Author

This is not fully working. On a setup where a developer doesn't have /var/reana tests will fail.

@diegodelemos diegodelemos reopened this Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diegodelemos diegodelemos

Labels
type/bug Something isn't working
Projects
No open projects
User-Quotas
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixtures: shared volume path through env variable diegodelemos/pytest-reana
1 participant
@diegodelemos