Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JobControllerAPIClient should have a constructor. #68

Open
dinosk opened this issue Nov 21, 2018 · 0 comments
Open

JobControllerAPIClient should have a constructor. #68

dinosk opened this issue Nov 21, 2018 · 0 comments
Labels
system/refactor type/goodfirstissue
Projects
Triage

Comments

@dinosk
Copy link
Member

dinosk commented Nov 21, 2018

The class

reana-commons/reana_commons/api_client.py

Line 63 in e720eaa

class JobControllerAPIClient(BaseAPIClient):
should have an __init__ method that passes reana-job-controller as service argument to the BaseAPIClient since its methods are designed to only work with this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
system/refactor type/goodfirstissue
Projects
Triage
Cluster future
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dinosk @diegodelemos