Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Unimplemented for ResourceRequirement #21

Open
anton-khodak opened this issue Feb 14, 2018 · 2 comments
Open

Return Unimplemented for ResourceRequirement #21

anton-khodak opened this issue Feb 14, 2018 · 2 comments

Comments

@anton-khodak
Copy link
Member

anton-khodak commented Feb 14, 2018

Related issues: reanahub/reana-job-controller#32, reanahub/reana-job-controller#31

@mr-c
Copy link
Member

mr-c commented Feb 14, 2018

Reason: reana-cwl-runner currently has no way to verify that the resources required are available on the assigned machine nor does it have the ability to request from REANA certain minimum machine resources (CPU cores, memory, storage space, etc..)

@tiborsimko tiborsimko added this to the CWL-Full-Conformance milestone Feb 19, 2018
@tiborsimko
Copy link
Member

Moving the milestone as the CWL test suite passes fully:

...
Test [125/128] Test simple workflow with a dynamic resource requirement
Test [126/128] Test that empty array input does not add anything to command line
Test [127/128] Test that ResourceRequirement on a step level redefines requirement on the workflow level
Test [128/128] Test valueFrom with constant value overriding provided array inputs
All tests passed

All tool tests succeeded

@diegodelemos diegodelemos removed this from the Someday milestone Oct 6, 2019
@diegodelemos diegodelemos added this to To triage in Triage Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Triage
To triage
Development

No branches or pull requests

4 participants