Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and expand data types. #15

Open
joseedil opened this issue Oct 8, 2020 · 4 comments
Open

Refactor and expand data types. #15

joseedil opened this issue Oct 8, 2020 · 4 comments

Comments

@joseedil
Copy link
Collaborator

joseedil commented Oct 8, 2020

This is being done in the refactor-datatypes branch, but it breaks the API.

The rational is the following:

@joseedil
Copy link
Collaborator Author

joseedil commented Oct 8, 2020

Content types: Everything is implemented.
Checking against the standard is still required.

  • <angle>
  • <anything>
  • <basic-shape>
  • <clock-value>
  • <color>
  • <coordinate>
  • <frequency>
  • <funcIRI>
  • <ICCColor>
  • <integer>
  • <IRI>
  • <Length>
  • <length-percentage> - This is commented so far in favor of <length> which includes a percentage format.
  • <list-of-Ts>
  • <name>
  • <number> - This one breaks the parser and almost everything else. Earlier implementation confounded <number> and <length>.
  • <number-optional-number>
  • <opacity-value>
  • <paint>
  • <percentage>
  • <time>
  • <transform-list>
  • <units> - This is not part of the standard but it is useful to define some attributes.
  • <URL>

@joseedil
Copy link
Collaborator Author

joseedil commented Oct 8, 2020

Attibutes: this is a big list, here are just what is missing, many of them because of the content types above.

  • begin
  • by
  • clip-path
  • contentScriptType
  • contentStyleType
  • cursor
  • d - Very relevant for paths!
  • decelerate - Definition is missing in the SVG website.
  • display
  • dur
  • end
  • filter
  • font-family
  • font-variant
  • from
  • g1
  • g2
  • glyph-name
  • gradientTransform
  • hreflang - Definition is missing in the SVG website.
  • id
  • keyPoints
  • keySplines
  • keyTimes
  • mask
  • max
  • media
  • min
  • offset - Definition is missing in the SVG website.
  • path
  • ping - Definition is missing in the SVG website.
  • points
  • referrerPolicy - Definition is missing in the SVG website.
  • rel - Definition is missing in the SVG website.
  • repeatDur
  • requiredExtensions - Definition is missing in the SVG website.
  • requiredFeatures
  • speed - Definition is missing in the SVG website.
  • stop-color
  • style
  • text-decoration
  • to
  • transform-origin - Definition is missing in the SVG website.
  • u1
  • u2
  • unicode-range
  • values
  • xlink:actuate - Definition is missing in the SVG website.
  • xlink:arcrole
  • xlink:href
  • xlink:role - Definition is missing in the SVG website.
  • xml:base

@joseedil
Copy link
Collaborator Author

joseedil commented Oct 8, 2020

Those are the SVG elements. Everything is missing so far.

  • <a>
  • <animate>
  • <animateMotion>
  • <animateTransform>
  • <circle>
  • <clipPath>
  • <color-profile>
  • <defs>
  • <desc>
  • <discard>
  • <ellipse>
  • <feBlend>
  • <feColorMatrix>
  • <feComponentTransfer>
  • <feComposite>
  • <feConvolveMatrix>
  • <feDiffuseLighting>
  • <feDisplacementMap>
  • <feDistantLight>
  • <feDropShadow>
  • <feFlood>
  • <feFuncA>
  • <feFuncB>
  • <feFuncG>
  • <feFuncR>
  • <feGaussianBlur>
  • <feImage>
  • <feMerge>
  • <feMergeNode>
  • <feMorphology>
  • <feOffset>
  • <fePointLight>
  • <feSpecularLighting>
  • <feSpotLight>
  • <feTile>
  • <feTurbulence>
  • <filter>
  • <foreignObject>
  • <g>
  • <hatch>
  • <hatchpath>
  • <image>
  • <line>
  • <linearGradient>
  • <marker>
  • <mask>
  • <mesh>
  • <meshgradient>
  • <meshpatch>
  • <meshrow>
  • <metadata>
  • <mpath>
  • <path>
  • <pattern>
  • <polygon>
  • <polyline>
  • <radialGradient>
  • <rect>
  • <script>
  • <set>
  • <solidcolor>
  • <stop>
  • <style>
  • <svg>
  • <switch>
  • <symbol>
  • <text>
  • <textPath>
  • <title>
  • <tspan>
  • <unknown>
  • <use>
  • <view\>

@lemmih
Copy link
Member

lemmih commented Oct 21, 2020

How much has to be implemented before we can merge this into master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants