Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change labelFontUrl to fontUrl for cluster #143

Merged
merged 1 commit into from
Nov 7, 2023
Merged

change labelFontUrl to fontUrl for cluster #143

merged 1 commit into from
Nov 7, 2023

Conversation

ljehezkiel
Copy link
Contributor

@ljehezkiel ljehezkiel commented Nov 7, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
Literally this is first time I contribute in github and pardon my english
I am modifying a line of code where if labelFontUrl is signed, label on cluster didn't work just like node label, it still show squareboxes
image
Literally just some typo in Cluster.js <Label> where should be fontUrl not labelFontUrl

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@amcdnl amcdnl merged commit 0ae3e14 into reaviz:master Nov 7, 2023
1 check passed
@ljehezkiel
Copy link
Contributor Author

ljehezkiel commented Nov 8, 2023

Hi, just ask when will this merged PR can be release?

@amcdnl
Copy link
Member

amcdnl commented Nov 8, 2023

Going out today@!

@ljehezkiel
Copy link
Contributor Author

ljehezkiel commented Nov 26, 2023

@amcdnl Hi, just kindly reminder
can we know when is the release of this update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants