Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to customise Label font size and offset #285

Merged
merged 6 commits into from
Oct 16, 2024
Merged

Conversation

SerhiiTsybulskyi
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for reagraph ready!

Name Link
🔨 Latest commit 5192c01
🔍 Latest deploy log https://app.netlify.com/sites/reagraph/deploys/670fc2c746cd4d0008ba0192
😎 Deploy Preview https://deploy-preview-285--reagraph.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@amcdnl amcdnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few minor nits

docs/Theme.mdx Outdated Show resolved Hide resolved
@@ -56,6 +56,8 @@ export interface Theme {
label?: {
stroke?: ColorRepresentation;
color: ColorRepresentation;
fontSize?: number;
yOffset?: number;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add docs to the props

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amcdnl What do you mean? Comment with description above or something else?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

src/themes/theme.ts Outdated Show resolved Hide resolved
@amcdnl amcdnl merged commit 63e11f3 into master Oct 16, 2024
5 checks passed
@amcdnl amcdnl deleted the extend-theme branch October 16, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants